Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant console logs from test output #935

Closed
2 tasks
bajtos opened this issue Jan 30, 2018 · 0 comments
Closed
2 tasks

Remove irrelevant console logs from test output #935

bajtos opened this issue Jan 30, 2018 · 0 comments
Assignees
Labels
developer-experience Issues affecting ease of use and overall experience of LB users tech-debt

Comments

@bajtos
Copy link
Member

bajtos commented Jan 30, 2018

Right now, the output of npm run mocha is littered with random log messages printed by some of the tests. This makes troubleshooting more difficult when one of the tests actually fail (e.g. on our CI), because it's not clear which messages are relevant to the test failure and which are just garbage.

We should fix all our tests so that they don't log anything on success.

Nice to have: an automated checker/linter that will fail the build when a test passes but still prints something to the console.

Acceptance criteria

  • The output of npm run mocha contains only a list of dot characters printed by Mocha's dot reporter.
  • A blog post explaining why it's a bad practice to have tests cluttering console output and what interesting design approaches and hacks we used to get rid of those logs.
@bajtos bajtos added developer-experience Issues affecting ease of use and overall experience of LB users tech-debt Core-GA labels Jan 30, 2018
raymondfeng added a commit that referenced this issue Jan 31, 2018
raymondfeng added a commit that referenced this issue Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants