fix(metadata): add more tests

loopbackio · Feb 5, 2018 · de969e4 · de969e4
1 parent c29dd19
commit de969e4
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/packages/metadata/src/decorator-factory.ts b/packages/metadata/src/decorator-factory.ts
@@ -284,12 +284,14 @@ export class DecoratorFactory<
         Reflector.getMetadata(this.key, target),
       );
       meta = this.mergeWithInherited(meta, target, member, descriptorOrIndex);
+      /* istanbul ignore if  */
       if (debug.enabled) {
         debug('%s: %j', targetName, meta);
       }
       Reflector.defineMetadata(this.key, meta, target);
     } else {
       meta = this.mergeWithOwn(meta, target, member, descriptorOrIndex);
+      /* istanbul ignore if  */
       if (debug.enabled) {
         debug('%s: %j', targetName, meta);
       }

diff --git a/packages/metadata/test/unit/decorator-factory.test.ts b/packages/metadata/test/unit/decorator-factory.test.ts
@@ -123,6 +123,38 @@ describe('ClassDecoratorFactory', () => {
   });
 });
 
+describe('ClassDecoratorFactory for primitive types', () => {
+  /**
+   * Define `@classDecorator(spec)`
+   * @param spec
+   */
+  function classDecorator(spec: number): ClassDecorator {
+    return ClassDecoratorFactory.createDecorator('test', spec);
+  }
+
+  const xSpec = 1;
+  @classDecorator(xSpec)
+  class BaseController {}
+
+  @classDecorator(2)
+  class SubController extends BaseController {}
+
+  it('applies metadata to a class', () => {
+    const meta = Reflector.getOwnMetadata('test', BaseController);
+    expect(meta).to.equal(xSpec);
+  });
+
+  it('merges with base class metadata', () => {
+    const meta = Reflector.getOwnMetadata('test', SubController);
+    expect(meta).to.equal(2);
+  });
+
+  it('does not mutate base class metadata', () => {
+    const meta = Reflector.getOwnMetadata('test', BaseController);
+    expect(meta).to.equal(1);
+  });
+});
+
 describe('ClassDecoratorFactory with create', () => {
   interface MySpec {
     x?: number;