fix: remove restriction to Entities from DefaultKeyValueRepository

KeyValue repository does not require Entities, it can be used with any model. This was an intentional decision when implementing LB3 key-value APIs, to allow the key value to be provided outside of the data stored, thus enabling use cases like storing arbitrary data (including binary blobs) via the key-value API. Signed-off-by: Miroslav Bajtoš <[email protected]>
loopbackio · Mar 30, 2020 · c30dce3 · c30dce3
1 parent 1daa2b8
commit c30dce3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/repository/src/repositories/kv.repository.bridge.ts b/packages/repository/src/repositories/kv.repository.bridge.ts
@@ -5,7 +5,7 @@
 
 import legacy from 'loopback-datasource-juggler';
 import {DataObject, Options} from '../common-types';
-import {Entity} from '../model';
+import {Model} from '../model';
 import {KeyValueFilter, KeyValueRepository} from './kv.repository';
 import {ensurePromise, juggler} from './legacy-juggler-bridge';
 
@@ -22,7 +22,7 @@ if (!(Symbol as any).asyncIterator) {
 /**
  * An implementation of KeyValueRepository based on loopback-datasource-juggler
  */
-export class DefaultKeyValueRepository<T extends Entity>
+export class DefaultKeyValueRepository<T extends Model>
   implements KeyValueRepository<T> {
   /**
    * A legacy KeyValueModel class
@@ -34,7 +34,7 @@ export class DefaultKeyValueRepository<T extends Entity>
    * @param ds - Legacy DataSource
    */
   constructor(
-    private entityClass: typeof Entity & {prototype: T},
+    private entityClass: typeof Model & {prototype: T},
     ds: juggler.DataSource,
   ) {
     // KVModel class is placeholder to receive methods from KeyValueAccessObject