fixup!: avoid polluting the options

loopbackio · Apr 16, 2019 · c15b4f7 · c15b4f7
1 parent 5ab7796
commit c15b4f7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/repository-json-schema/src/__tests__/integration/build-schema.integration.ts b/packages/repository-json-schema/src/__tests__/integration/build-schema.integration.ts
@@ -680,6 +680,18 @@ describe('build-schema', () => {
         },
       });
     });
+    it('does not pollute the options', () => {
+      @model()
+      class Category {
+        @property()
+        name: string;
+      }
+
+      const SCHEMA_OPTIONS = {};
+      // tslint:disable-next-line:no-unused
+      const categorySchema = getJsonSchema(Category, SCHEMA_OPTIONS);
+      expect(SCHEMA_OPTIONS).to.be.empty();
+    });
     context('circular reference', () => {
       @model()
       class Category {

diff --git a/packages/repository-json-schema/src/build-schema.ts b/packages/repository-json-schema/src/build-schema.ts
@@ -153,8 +153,9 @@ export function metaToJsonProperty(meta: PropertyDefinition): JSONSchema {
  */
 export function modelToJsonSchema(
   ctor: Function,
-  options: JsonSchemaOptions = {},
+  jsonSchemaOptions: JsonSchemaOptions = {},
 ): JSONSchema {
+  const options = {...jsonSchemaOptions};
   options.visited = options.visited || {};
 
   const meta: ModelDefinition | {} = ModelMetadataHelper.getModelMetadata(ctor);