Skip to content

Commit

Permalink
refactor(booter-lb3app): move boot/core/rest to dev-dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
bajtos committed Feb 12, 2019
1 parent 54579dd commit 8e95629
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 8 deletions.
13 changes: 8 additions & 5 deletions SPIKE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,14 @@ production-ready implementation.
can create an entirely new page.

3. Implement `@loopback/booter-lb3app`, including test coverage and
documentation. As part of this effort, create a new package to hold types
needed by Booter implementations. The idea is to decouple API contract
between Bootstrapper and Booters from the actual Bootstrapper implementation.
`@loopback/booter-lb3app` should not have any runtime dependency on
`@loopback/boot` (a dev-dependency for tests is ok).
documentation. The booter package should not have any runtime dependency on
`@loopback/boot`, it should use `peerDependencies` to specify which core
packages it works with and dev-dependencies for development & testing. List
of packages to put in peer dependencies:

- `@loopback/core`
- `@loopback/boot`
- `@loopback/rest`

4. Create an example app based on `loopback-getting-started`
(`@loopback/example-lb3app`) to showcase LB3+LB4 integration. Add acceptance
Expand Down
11 changes: 8 additions & 3 deletions packages/booter-lb3app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
"copyright.owner": "IBM Corp.",
"license": "MIT",
"dependencies": {
"@loopback/boot": "^1.0.12",
"@loopback/core": "^1.1.6",
"@loopback/rest": "^1.5.5",
"@types/debug": "^4.1.0",
"@types/express": "^4.16.1",
"@types/p-event": "^1.3.0",
Expand All @@ -28,8 +25,16 @@
"p-event": "^2.2.0",
"swagger2openapi": "^5.2.1"
},
"peerDependencies": {
"@loopback/boot": "^1.0.12",
"@loopback/core": "^1.1.6",
"@loopback/rest": "^1.5.5"
},
"devDependencies": {
"@loopback/boot": "^1.0.12",
"@loopback/core": "^1.1.6",
"@loopback/build": "^1.3.0",
"@loopback/rest": "^1.5.5",
"@loopback/testlab": "^1.0.6",
"@loopback/tslint-config": "^2.0.0",
"@types/node": "^10.1.1"
Expand Down

0 comments on commit 8e95629

Please sign in to comment.