feat(build): add more TypeScript "strict" checks

Enable all "strict" checks with the exception of
`strictPropertyInitialization` which would require significant changes.

The following additional checks are added:

- noImplicitThis
- alwaysStrict
- strictFunctionTypes

In the future, any checks added to TypeScript "strict" mode will be
automatically enabled for LoopBack projects too.

benchmark/src/benchmark.ts

@@ -5,7 +5,7 @@
 
 import * as byline from 'byline';
 import {ChildProcess, spawn} from 'child_process';
-import pEvent from 'p-event';
+import pEvent, {Emitter} from 'p-event';
 import {Autocannon, EndpointStats} from './autocannon';
 import {Client} from './client';
 import {scenarios} from './scenarios';
@@ -111,5 +111,10 @@ function startWorker() {
 
 async function closeWorker(worker: ChildProcess) {
   worker.kill();
-  await pEvent(worker, 'close');
+  await pEvent(
+    // workaround for a bug in pEvent types which makes them
+    // incompatible with "strictFunctionTypes"
+    worker as Emitter<[unknown]>,
+    'close',
+  );
 }

packages/build/config/tsconfig.common.json

@@ -3,11 +3,12 @@
   "compilerOptions": {
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
-    "noImplicitAny": true,
-    "strictNullChecks": true,
     "resolveJsonModule": true,
-    "strictBindCallApply": true,
     "skipLibCheck": true,
+    "strict": true,
+
+    // FIXME(bajtos) LB4 is not compatible with this setting yet
+    "strictPropertyInitialization": false,
 
     "lib": ["es2018", "esnext.asynciterable"],
     "module": "commonjs",

packages/context/src/__tests__/acceptance/class-level-bindings.acceptance.ts

@@ -458,8 +458,8 @@ describe('Context bindings - Injecting dependencies of classes', () => {
         'location',
         {},
         // Set up a custom resolve() to access information from the session
-        (c: Context, injection: Injection, session: ResolutionSession) => {
-          resolutionPath = session.getResolutionPath();
+        (c: Context, injection: Injection, session?: ResolutionSession) => {
+          resolutionPath = session ? session.getResolutionPath() : undefined;
           return 'San Jose';
         },
       )

packages/context/src/__tests__/unit/resolver.unit.ts

@@ -213,7 +213,9 @@ describe('constructor injection', () => {
         'p',
         {},
         // Set up a custom resolve() to access information from the session
-        (c: Context, injection: Injection, session: ResolutionSession) => {
+        (c: Context, injection: Injection, session?: ResolutionSession) => {
+          if (!session)
+            throw new Error('Resolver was called with no ResolutionSession');
           bindingPath = session.getBindingPath();
           resolutionPath = session.getResolutionPath();
         },
@@ -251,7 +253,9 @@ describe('constructor injection', () => {
         'p',
         {},
         // Set up a custom resolve() to access information from the session
-        (c: Context, injection: Injection, session: ResolutionSession) => {
+        (c: Context, injection: Injection, session?: ResolutionSession) => {
+          if (!session)
+            throw new Error('Resolver was called with no ResolutionSession');
           bindingPath = session.getBindingPath();
           resolutionPath = session.getResolutionPath();
           decorators = session.injectionStack.map(i => i.metadata!.decorator);
@@ -290,7 +294,9 @@ describe('constructor injection', () => {
         'p',
         {},
         // Set up a custom resolve() to access information from the session
-        (c: Context, injection: Injection, session: ResolutionSession) => {
+        (c: Context, injection: Injection, session?: ResolutionSession) => {
+          if (!session)
+            throw new Error('Resolver was called with no ResolutionSession');
           injectionPath = session.getInjectionPath();
         },
       )

packages/context/src/context-view.ts

@@ -40,11 +40,16 @@ export class ContextView<T = unknown> extends EventEmitter
   protected _cachedValues: T[] | undefined;
   private _subscription: Subscription | undefined;
 
-  constructor(
-    protected readonly context: Context,
-    public readonly filter: BindingFilter<T>,
-  ) {
+  // Workaround to pass TypeScript's "strictFunctionTypes" check:
+  // Type 'BindingFilter<T>' is not assignable to type 'BindingFilter<unknown>'.
+  //   Type 'unknown' is not assignable to type 'T'.
+  readonly filter: BindingFilter<unknown>;
+
+  constructor(protected readonly context: Context, filter: BindingFilter<T>) {
     super();
+
+    // Workaround to pass TypeScript's "strictFunctionTypes" check
+    this.filter = filter as BindingFilter<unknown>;
   }
 
   /**
@@ -85,10 +90,11 @@ export class ContextView<T = unknown> extends EventEmitter
   /**
    * Find matching bindings and refresh the cache
    */
-  protected findBindings() {
+  protected findBindings(): Readonly<Binding<T>>[] {
     debug('Finding matching bindings');
-    this._cachedBindings = this.context.find(this.filter);
-    return this._cachedBindings;
+    const found = this.context.find(this.filter);
+    this._cachedBindings = found;
+    return found;
   }
 
   /**

packages/repository/src/__tests__/unit/type-resolver.unit.ts

@@ -4,7 +4,12 @@
 // License text available at https://opensource.org/licenses/MIT
 
 import {expect} from '@loopback/testlab';
-import {isBuiltinType, isTypeResolver, resolveType} from '../../type-resolver';
+import {
+  isBuiltinType,
+  isTypeResolver,
+  resolveType,
+  TypeResolver,
+} from '../../type-resolver';
 
 class SomeModel {
   constructor(public name: string) {}
@@ -60,7 +65,8 @@ describe('isTypeResolver', () => {
 
 describe('resolveType', () => {
   it('resolves the arg when the value is a resolver', () => {
-    const ctor = resolveType(() => SomeModel);
+    const resolver: TypeResolver<SomeModel> = () => SomeModel;
+    const ctor = resolveType(resolver);
     expect(ctor).to.eql(SomeModel);
 
     const inst = new ctor('a-name');