fix: optimize serving static files

Optimize serving static files

packages/rest/src/rest.server.ts

@@ -46,6 +46,7 @@ import {
   Send,
 } from './types';
 import {ServerOptions} from 'https';
+import * as HttpErrors from 'http-errors';
 
 const debug = require('debug')('loopback:rest:server');
 
@@ -190,6 +191,15 @@ export class RestServer extends Context implements Server, HttpServerLike {
     this._setupRequestHandler();
 
     this.bind(RestBindings.HANDLER).toDynamicValue(() => this.httpHandler);
+
+    // LB4's static assets serving router
+    const staticAssetsRouter = new Route('get', '*', {responses: {}}, () => {
+      console.log('>> staticAssetsRouter HANDLER');
+      // @bajtos How do we access req and res here?
+      return 'HELLO!';
+    });
+
+    this.httpHandler.registerRoute(staticAssetsRouter);
   }
 
   protected _setupRequestHandler() {
@@ -243,7 +253,6 @@ export class RestServer extends Context implements Server, HttpServerLike {
   protected _setupRouterForStaticAssets() {
     if (!this._routerForStaticAssets) {
       this._routerForStaticAssets = express.Router();
-      this._expressApp.use(this._routerForStaticAssets);
     }
   }
 
@@ -596,15 +605,7 @@ export class RestServer extends Context implements Server, HttpServerLike {
    * @param rootDir The root directory from which to serve static assets
    * @param options Options for serve-static
    */
-  static(path: PathParams, rootDir: string, options?: ServeStaticOptions) {
-    const re = pathToRegExp(path, [], {end: false});
-    if (re.test('/')) {
-      throw new Error(
-        'Static assets cannot be mount to "/" to avoid performance penalty.',
-      );
-    }
-    this._routerForStaticAssets.use(path, express.static(rootDir, options));
-  }
+  static(path: PathParams, rootDir: string, options?: ServeStaticOptions) {}
 
   /**
    * Set the OpenAPI specification that defines the REST API schema for this

packages/rest/src/router/router-base.ts

@@ -49,6 +49,11 @@ export abstract class BaseRouter implements RestRouter {
     else return this.findRouteWithPathVars(request);
   }
 
+  getStaticAssetsRouter() {
+    let route = this.routesWithoutPathVars['/get/*'];
+    return createResolvedRoute(route, {});
+  }
+
   list() {
     let routes = Object.values(this.routesWithoutPathVars);
     routes = routes.concat(this.listRoutesWithPathVars());

packages/rest/src/router/routing-table.ts

@@ -72,6 +72,8 @@ export interface RestRouter {
    */
   find(request: Request): ResolvedRoute | undefined;
 
+  getStaticAssetsRouter(): ResolvedRoute;
+
   /**
    * List all routes
    */
@@ -136,6 +138,8 @@ export class RoutingTable {
    * @param route A route entry
    */
   registerRoute(route: RouteEntry) {
+    // console.log(`>> ROUTING TABLE registerRoute A`);
+    // console.log(route);
     // TODO(bajtos) handle the case where opSpec.parameters contains $ref
     // See https://github.com/strongloop/loopback-next/issues/435
     if (debug.enabled) {
@@ -180,10 +184,8 @@ export class RoutingTable {
       return found;
     }
 
-    debug('No route found for %s %s', request.method, request.path);
-    throw new HttpErrors.NotFound(
-      `Endpoint "${request.method} ${request.path}" not found.`,
-    );
+    const staticAssetsRouter = this._router.getStaticAssetsRouter();
+    return staticAssetsRouter;
   }
 }
 
@@ -290,7 +292,7 @@ export class Route extends BaseRoute {
     verb: string,
     path: string,
     public readonly spec: OperationObject,
-    protected readonly _handler: Function,
+    protected readonly _handler: Function, // <-- doesn't this Function have a signature?
   ) {
     super(verb, path, spec);
   }