feat(rest): support controllers added after start

A short-term workaround for the missing feature tracked by
#433

Signed-off-by: Miroslav Bajtoš <[email protected]>

packages/rest/src/rest.application.ts

@@ -133,6 +133,11 @@ export class RestApplication extends Application implements HttpServerLike {
     this.restServer.basePath(path);
   }
 
+  controller<T>(controllerCtor: ControllerClass<T>, name?: string): Binding {
+    this.restServer.invalidateRoutingCache();
+    return super.controller(controllerCtor, name);
+  }
+
   /**
    * Register a new Controller-based route.
    *

packages/rest/src/rest.server.ts

@@ -464,6 +464,11 @@ export class RestServer extends Context implements Server, HttpServerLike {
     response.redirect(302, fullUrl);
   }
 
+  // workaround for https://github.com/strongloop/loopback-next/issues/433
+  invalidateRoutingCache(): void {
+    delete this._httpHandler;
+  }
+
   /**
    * Register a controller class with this server.
    *
@@ -482,6 +487,9 @@ export class RestServer extends Context implements Server, HttpServerLike {
    *
    */
   controller(controllerCtor: ControllerClass<ControllerInstance>): Binding {
+    this.invalidateRoutingCache();
+    // FIXME(bajtos) This code is never used, a typical LB4 app is binding
+    // controller via `app.controller()` API
     return this.bind('controllers.' + controllerCtor.name).toClass(
       controllerCtor,
     );
@@ -564,6 +572,8 @@ export class RestServer extends Context implements Server, HttpServerLike {
     controllerFactory?: ControllerFactory<T>,
     methodName?: string,
   ): Binding {
+    this.invalidateRoutingCache();
+
     if (typeof routeOrVerb === 'object') {
       const r = routeOrVerb;
       // Encode the path to escape special chars
@@ -703,6 +713,9 @@ export class RestServer extends Context implements Server, HttpServerLike {
     let spec = this.getSync<OpenApiSpec>(RestBindings.API_SPEC);
     const defs = this.httpHandler.getApiDefinitions();
 
+    // Apply shallow-clone to prevent modification of user-provided API_SPEC
+    spec = {...spec};
+
     // Apply deep clone to prevent getApiSpec() callers from
     // accidentally modifying our internal routing data
     spec.paths = cloneDeep(this.httpHandler.describeApiPaths());