test(cli): extract test suite for checking loopback project directory

Signed-off-by: Miroslav Bajtoš <[email protected]>
loopbackio · Sep 23, 2019 · 2ca6413 · 2ca6413
1 parent 1dc05cc
commit 2ca6413
Show file tree

Hide file tree

Showing 2 changed files with 92 additions and 78 deletions.
diff --git a/packages/cli/test/integration/lib/artifact-generator.js b/packages/cli/test/integration/lib/artifact-generator.js
@@ -6,9 +6,8 @@
 'use strict';
 const assert = require('yeoman-assert');
 const sinon = require('sinon');
-const chalk = require('chalk');
 const testUtils = require('../../test-utils');
-const fs = require('mem-fs-editor').create(require('mem-fs').create());
+const suiteCheckLoopBackProject = require('./check-loopback-project.suite');
 
 module.exports = function(artiGenerator) {
   return function() {
@@ -57,82 +56,7 @@ module.exports = function(artiGenerator) {
       });
     });
 
-    describe('checkLoopBackProject', () => {
-      let gen;
-
-      beforeEach(() => {
-        gen = testUtils.testSetUpGen(artiGenerator);
-        gen.fs.readJSON = sinon.stub(fs, 'readJSON');
-      });
-
-      afterEach(() => {
-        if (gen) gen.fs.readJSON.restore();
-      });
-
-      testCheckLoopBack(
-        'throws an error if no package.json is present',
-        undefined,
-        /No package.json found/,
-      );
-
-      testCheckLoopBack(
-        'throws an error if "@loopback/core" is not a dependency',
-        {dependencies: {}},
-        /No `@loopback\/core` package found/,
-      );
-
-      testCheckLoopBack(
-        'throws an error if dependencies have incompatible versions',
-        {
-          dependencies: {
-            '@loopback/context': '^0.0.0',
-            '@loopback/core': '^0.0.0',
-          },
-        },
-        /Incompatible dependencies/,
-      );
-
-      testCheckLoopBack(
-        'allows */x/X for version range',
-        {
-          devDependencies: {'@types/node': '*'},
-          dependencies: {
-            '@loopback/context': 'x.x',
-            '@loopback/core': 'X.*',
-          },
-        },
-        // No expected error here
-      );
-
-      it('passes if "@loopback/core" is a dependency', async () => {
-        await gen.checkLoopBackProject();
-      });
-
-      function testCheckLoopBack(testName, obj, expected) {
-        it(testName, async () => {
-          let logs = [];
-          gen.log = function(...args) {
-            logs = logs.concat(args);
-          };
-          gen.prompt = async () => ({
-            ignoreIncompatibleDependencies: false,
-          });
-          gen.fs.readJSON.returns(obj);
-          await gen.checkLoopBackProject();
-          if (!expected) {
-            assert(gen.exitGeneration == null);
-            return;
-          }
-          assert(gen.exitGeneration instanceof Error);
-          assert(gen.exitGeneration.message.match(expected));
-          gen.end();
-          assert.equal(
-            logs[logs.length - 1],
-            chalk.red('Generation is aborted:', gen.exitGeneration),
-          );
-        });
-      }
-    });
+    suiteCheckLoopBackProject(artiGenerator);
 
     describe('promptArtifactName', () => {
       let gen;

diff --git a/packages/cli/test/integration/lib/check-loopback-project.suite.js b/packages/cli/test/integration/lib/check-loopback-project.suite.js
@@ -0,0 +1,90 @@
+// Copyright IBM Corp. 2018. All Rights Reserved.
+// Node module: @loopback/cli
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+'use strict';
+const assert = require('yeoman-assert');
+const sinon = require('sinon');
+const chalk = require('chalk');
+const testUtils = require('../../test-utils');
+const fs = require('mem-fs-editor').create(require('mem-fs').create());
+
+module.exports = function suiteCheckLoopBackProject(generator) {
+  describe('checkLoopBackProject', () => {
+    let gen;
+
+    beforeEach(() => {
+      gen = testUtils.testSetUpGen(generator);
+      gen.fs.readJSON = sinon.stub(fs, 'readJSON');
+    });
+
+    afterEach(() => {
+      if (gen) gen.fs.readJSON.restore();
+    });
+
+    testCheckLoopBack(
+      'throws an error if no package.json is present',
+      undefined,
+      /No package.json found/,
+    );
+
+    testCheckLoopBack(
+      'throws an error if "@loopback/core" is not a dependency',
+      {dependencies: {}},
+      /No `@loopback\/core` package found/,
+    );
+
+    testCheckLoopBack(
+      'throws an error if dependencies have incompatible versions',
+      {
+        dependencies: {
+          '@loopback/context': '^0.0.0',
+          '@loopback/core': '^0.0.0',
+        },
+      },
+      /Incompatible dependencies/,
+    );
+
+    testCheckLoopBack(
+      'allows */x/X for version range',
+      {
+        devDependencies: {'@types/node': '*'},
+        dependencies: {
+          '@loopback/context': 'x.x',
+          '@loopback/core': 'X.*',
+        },
+      },
+      // No expected error here
+    );
+
+    it('passes if "@loopback/core" is a dependency', async () => {
+      await gen.checkLoopBackProject();
+    });
+
+    function testCheckLoopBack(testName, obj, expected) {
+      it(testName, async () => {
+        let logs = [];
+        gen.log = function(...args) {
+          logs = logs.concat(args);
+        };
+        gen.prompt = async () => ({
+          ignoreIncompatibleDependencies: false,
+        });
+        gen.fs.readJSON.returns(obj);
+        await gen.checkLoopBackProject();
+        if (!expected) {
+          assert(gen.exitGeneration == null);
+          return;
+        }
+        assert(gen.exitGeneration instanceof Error);
+        assert(gen.exitGeneration.message.match(expected));
+        gen.end();
+        assert.equal(
+          logs[logs.length - 1],
+          chalk.red('Generation is aborted:', gen.exitGeneration),
+        );
+      });
+    }
+  });
+};