fixup!: avoid polluting the options

loopbackio · Apr 16, 2019 · 20bb8a2 · 20bb8a2
1 parent 5ab7796
commit 20bb8a2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,7 +1,5 @@
 {
-  "editor.rulers": [
-    80
-  ],
+  "editor.rulers": [80],
   "editor.tabCompletion": "on",
   "editor.tabSize": 2,
   "editor.trimAutoWhitespace": true,

diff --git a/packages/repository-json-schema/src/__tests__/integration/build-schema.integration.ts b/packages/repository-json-schema/src/__tests__/integration/build-schema.integration.ts
@@ -680,6 +680,18 @@ describe('build-schema', () => {
         },
       });
     });
+    it('does not pollute the JSON schema options', () => {
+      @model()
+      class Category {
+        @property()
+        name: string;
+      }
+
+      const JSON_SCHEMA_OPTIONS = {};
+      // tslint:disable-next-line:no-unused
+      const categorySchema = getJsonSchema(Category, JSON_SCHEMA_OPTIONS);
+      expect(JSON_SCHEMA_OPTIONS).to.be.empty();
+    });
     context('circular reference', () => {
       @model()
       class Category {

diff --git a/packages/repository-json-schema/src/build-schema.ts b/packages/repository-json-schema/src/build-schema.ts
@@ -153,8 +153,9 @@ export function metaToJsonProperty(meta: PropertyDefinition): JSONSchema {
  */
 export function modelToJsonSchema(
   ctor: Function,
-  options: JsonSchemaOptions = {},
+  jsonSchemaOptions: JsonSchemaOptions = {},
 ): JSONSchema {
+  const options = {...jsonSchemaOptions};
   options.visited = options.visited || {};
 
   const meta: ModelDefinition | {} = ModelMetadataHelper.getModelMetadata(ctor);