fix: review 1

review 1
loopbackio · Oct 23, 2018 · 1609efb · 1609efb
1 parent e8c7033
commit 1609efb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 18 deletions.
diff --git a/packages/rest/src/router/routing-table.ts b/packages/rest/src/router/routing-table.ts
@@ -156,13 +156,12 @@ export class RoutingTable {
     const paths: PathObject = {};
 
     for (const route of this._router.list()) {
-      if (!route.spec['x-internal']) {
-        if (!paths[route.path]) {
-          paths[route.path] = {};
-        }
-
-        paths[route.path][route.verb] = route.spec;
+      if (route.spec['x-internal']) continue;
+      if (!paths[route.path]) {
+        paths[route.path] = {};
       }
+
+      paths[route.path][route.verb] = route.spec;
     }
 
     return paths;
@@ -189,10 +188,6 @@ export class RoutingTable {
   }
 }
 
-export interface LB4OperationObject extends OperationObject {
-  readonly 'x-internal'?: boolean;
-}
-
 /**
  * An entry in the routing table
  */
@@ -208,7 +203,7 @@ export interface RouteEntry {
   /**
    * OpenAPI operation spec
    */
-  readonly spec: LB4OperationObject;
+  readonly spec: OperationObject;
 
   /**
    * Update bindings for the request context

diff --git a/packages/rest/test/unit/rest.server/rest.server.open-api-spec.unit.ts b/packages/rest/test/unit/rest.server/rest.server.open-api-spec.unit.ts
@@ -90,14 +90,12 @@ describe('RestServer.getApiSpec()', () => {
     function greet() {}
     function meet() {}
     server.route(
-      new Route(
-        'get',
-        '/greet',
-        {'x-internal': true, responses: {}, spec: {}},
-        greet,
-      ),
+      'get',
+      '/greet',
+      {'x-internal': true, responses: {}, spec: {}},
+      greet,
     );
-    server.route(new Route('get', '/meet', {responses: {}, spec: {}}, meet));
+    server.route('get', '/meet', {responses: {}, spec: {}}, meet);
     const spec = server.getApiSpec();
     expect(spec.paths).to.eql({
       '/meet': {