fixup! apply most feedback

docs/site/tutorials/todo-list/todo-list-tutorial-repository.md

@@ -109,11 +109,13 @@ async find(
   // Prevent juggler for applying "include" filter
   // Juggler is not aware of LB4 relations
   const include = filter && filter.include;
-  filter = filter && Object.assign(filter, {include: undefined});
+  filter = {...filter, include: undefined};
   const result = await super.find(filter, options);
 
   // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
   // and use `inq` operator to fetch related todos in fewer DB queries
+  // this is a temporary implementation, please see
+  // https://github.com/strongloop/loopback-next/issues/3195
   if (include && include.length && include[0].relation === 'todos') {
     await Promise.all(
       result.map(async r => {
@@ -133,10 +135,14 @@ async findById(
   // Prevent juggler for applying "include" filter
   // Juggler is not aware of LB4 relations
   const include = filter && filter.include;
-  filter = filter && Object.assign(filter, {include: undefined});
+  filter = {...filter, include: undefined};
 
   const result = await super.findById(id, filter, options);
 
+  // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+  // and use `inq` operator to fetch related todos in fewer DB queries
+  // this is a temporary implementation, please see
+  // https://github.com/strongloop/loopback-next/issues/3195
   if (include && include.length && include[0].relation === 'todos') {
     result.todos = await this.todos(result.id).find();
   }
@@ -151,12 +157,12 @@ your related `Todo`s, for example:
 ```json
 {
   "id": 2,
-  "title": "daily routine of POTUS",
+  "title": "My daily chores",
   "todos": [
     {
       "id": 3,
-      "title": "terrorize senate",
-      "desc": "Tell them they're getting a budget cut.",
+      "title": "play space invaders",
+      "desc": "Become the very best!",
       "todoListId": 2
     }
   ]
@@ -175,12 +181,14 @@ async find(
   // Prevent juggler for applying "include" filter
   // Juggler is not aware of LB4 relations
   const include = filter && filter.include;
-  filter = filter && Object.assign(filter, {include: undefined});
+  filter = {...filter, include: undefined};
 
   const result = await super.find(filter, options);
 
   // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
-  // and use `inq` operator to fetch related todo-lists in fewer DB queries
+    // and use `inq` operator to fetch related todo-lists in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
   if (include && include.length && include[0].relation === 'todoList') {
     await Promise.all(
       result.map(async r => {
@@ -200,10 +208,14 @@ async findById(
   // Prevent juggler for applying "include" filter
   // Juggler is not aware of LB4 relations
   const include = filter && filter.include;
-  filter = filter && Object.assign(filter, {include: undefined});
+  filter = {...filter, include: undefined};
 
   const result = await super.findById(id, filter, options);
 
+  // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+  // and use `inq` operator to fetch related todo-lists in fewer DB queries
+  // this is a temporary implementation, please see
+  // https://github.com/strongloop/loopback-next/issues/3195
   if (include && include.length && include[0].relation === 'todoList') {
     result.todoList = await this.todoList(result.id);
   }

examples/todo-list/src/__tests__/integration/todo-list-image.integration.ts → examples/todo-list/src/__tests__/integration/todo-list-image.repository.integration.ts

@@ -8,7 +8,7 @@ import {
   givenTodoListRepositories,
 } from '../helpers';
 
-describe('TodoListApplication', () => {
+describe('TodoListImageRepository', () => {
   let app: TodoListApplication;
   let todoListImageRepo: TodoListImageRepository;
   let todoListRepo: TodoListRepository;

examples/todo-list/src/__tests__/integration/todo-list.integration.ts → examples/todo-list/src/__tests__/integration/todo-list.repository.integration.ts

@@ -8,7 +8,7 @@ import {
   givenTodoRepositories,
 } from '../helpers';
 
-describe('TodoListApplication', () => {
+describe('TodoListRepository', () => {
   let app: TodoListApplication;
   let todoRepo: TodoRepository;
   let todoListRepo: TodoListRepository;

examples/todo-list/src/__tests__/integration/todo.integration.ts → examples/todo-list/src/__tests__/integration/todo.repository.integration.ts

@@ -8,7 +8,7 @@ import {
   givenTodoRepositories,
 } from '../helpers';
 
-describe('TodoListApplication', () => {
+describe('TodoRepository', () => {
   let app: TodoListApplication;
   let todoRepo: TodoRepository;
   let todoListRepo: TodoListRepository;

examples/todo-list/src/repositories/todo-list-image.repository.ts

@@ -48,11 +48,14 @@ export class TodoListImageRepository extends DefaultCrudRepository<
     // Prevent juggler for applying "include" filter
     // Juggler is not aware of LB4 relations
     const include = filter && filter.include;
-    filter = filter && Object.assign(filter, {include: undefined});
+    filter = {...filter, include: undefined};
 
     const result = await super.find(filter, options);
 
-    // this is a temporary implementation, please see https://github.com/strongloop/loopback-next/issues/3195
+    // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+    // and use `inq` operator to fetch related todo-lists in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
     if (include && include.length && include[0].relation === 'todoList') {
       await Promise.all(
         result.map(async r => {
@@ -72,10 +75,14 @@ export class TodoListImageRepository extends DefaultCrudRepository<
     // Prevent juggler for applying "include" filter
     // Juggler is not aware of LB4 relations
     const include = filter && filter.include;
-    filter = filter && Object.assign(filter, {include: undefined});
+    filter = {...filter, include: undefined};
 
     const result = await super.findById(id, filter, options);
 
+    // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+    // and use `inq` operator to fetch related todo-lists in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
     if (include && include.length && include[0].relation === 'todoList') {
       result.todoList = await this.todoList(result.id);
     }

examples/todo-list/src/repositories/todo-list.repository.ts

@@ -66,10 +66,13 @@ export class TodoListRepository extends DefaultCrudRepository<
     // Prevent juggler for applying "include" filter
     // Juggler is not aware of LB4 relations
     const include = filter && filter.include;
-    filter = filter && Object.assign(filter, {include: undefined});
+    filter = {...filter, include: undefined};
     const result = await super.find(filter, options);
 
-    // this is a temporary implementation, please see https://github.com/strongloop/loopback-next/issues/3195
+    // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+    // and use `inq` operator to fetch related todos in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
     if (include && include.length && include[0].relation === 'todos') {
       await Promise.all(
         result.map(async r => {
@@ -89,10 +92,14 @@ export class TodoListRepository extends DefaultCrudRepository<
     // Prevent juggler for applying "include" filter
     // Juggler is not aware of LB4 relations
     const include = filter && filter.include;
-    filter = filter && Object.assign(filter, {include: undefined});
+    filter = {...filter, include: undefined};
 
     const result = await super.findById(id, filter, options);
 
+    // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+    // and use `inq` operator to fetch related todos in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
     if (include && include.length && include[0].relation === 'todos') {
       result.todos = await this.todos(result.id).find();
     }

examples/todo-list/src/repositories/todo.repository.ts

@@ -45,11 +45,14 @@ export class TodoRepository extends DefaultCrudRepository<
     // Prevent juggler for applying "include" filter
     // Juggler is not aware of LB4 relations
     const include = filter && filter.include;
-    filter = filter && Object.assign(filter, {include: undefined});
+    filter = {...filter, include: undefined};
 
     const result = await super.find(filter, options);
 
-    // this is a temporary implementation, please see https://github.com/strongloop/loopback-next/issues/3195
+    // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+    // and use `inq` operator to fetch related todo-lists in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
     if (include && include.length && include[0].relation === 'todoList') {
       await Promise.all(
         result.map(async r => {
@@ -69,10 +72,14 @@ export class TodoRepository extends DefaultCrudRepository<
     // Prevent juggler for applying "include" filter
     // Juggler is not aware of LB4 relations
     const include = filter && filter.include;
-    filter = filter && Object.assign(filter, {include: undefined});
+    filter = {...filter, include: undefined};
 
     const result = await super.findById(id, filter, options);
 
+    // poor-mans inclusion resolver, this should be handled by DefaultCrudRepo
+    // and use `inq` operator to fetch related todo-lists in fewer DB queries
+    // this is a temporary implementation, please see
+    // https://github.com/strongloop/loopback-next/issues/3195
     if (include && include.length && include[0].relation === 'todoList') {
       result.todoList = await this.todoList(result.id);
     }