Skip to content

Commit

Permalink
fixup! address Biniam's feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
bajtos committed Apr 16, 2019
1 parent 687a751 commit 09bc09a
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions _SPIKE_.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,6 @@ Introduce a new property metadata "references" (inspired by ANSI SQL):
references: {
// a TypeResolver
model: () => Category,
// or a Model class
model: Category
// or a Model name
model: 'Category'

// name of the target property
property: 'id',
Expand Down Expand Up @@ -324,6 +320,10 @@ connector cannot process. The flag can allow three values:
[ModelDefinition.prototype.indexes()](https://github.com/strongloop/loopback-datasource-juggler/blob/fe83f3cfd11f3fa313a5f9a253149a3b8479a572/lib/
model-definition.js#L194) API in favor of this new `Connector` method.

Create follow-up tasks to leverage the new helper in our NoSQL connectors and
thus let the connectors understand the new FK/INDEX definition syntax. (One
GH issue per connector please.)

4. Spike: a template implementation of index & constraint migration in
`SqlConnector`. The intention is to share as much of index/FK migration logic
among all SQL connectors. This spike will allow us to better understand the
Expand All @@ -335,6 +335,10 @@ connector cannot process. The flag can allow three values:

Detect index/FK metadata not supported by SQL and report warnings to console.

Create follow-up tasks to leverage the new helper in our SQL connectors and
thus let the connectors understand the new FK/INDEX definition syntax. (One
GH issue per connector please.)

5. Modify the description of the story to implement index/FK in `memory`
connector, require the connector to warn about index/PK fields not supported.

Expand Down

0 comments on commit 09bc09a

Please sign in to comment.