Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed DataType condition that breaks $exists lookups in mongoDB #856

Closed
wants to merge 2 commits into from
Closed

Removed DataType condition that breaks $exists lookups in mongoDB #856

wants to merge 2 commits into from

Conversation

jsheely
Copy link
Contributor

@jsheely jsheely commented Feb 14, 2016

I'm not entirely sure what this DataType(val) check is even needed for.

But in a query like this:

http://localhost:4001/api/products?filter[where][tags][exists]=true

This method will return: "[object, Object]" instead of using the actual object {exists: true} which will get converted later in the buildWhere in mongoDB to {$exists: true}

@slnode
Copy link

slnode commented Feb 14, 2016

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@jsheely
Copy link
Contributor Author

jsheely commented Feb 14, 2016

This is related to this issue: strongloop/loopback#1009 for mongoDB

@jfurie
Copy link

jfurie commented Feb 17, 2016

+1

@ssh24
Copy link
Contributor

ssh24 commented Apr 5, 2017

@jsheely Looks like you had this branch on your old fork which you deleted. If you look at the top it says:
jsheely wants to merge 2 commits into strongloop:master from unknown repository

Closing this PR for that reason. Please create a new one and assign me to it so that I can take a look.

@ssh24 ssh24 closed this Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants