Make sure inclusion filter is applied to the target model #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2015
|
|
||
| it('should apply inclusion fields to the target model', function(done) { | ||
| Article.create({title: 'a1'}, function (e, article) { | ||
| should.not.exist(e); |
There was a problem hiding this comment.
Consider replacing should.not.exist(e) with if (e) return done(e);. The latter gives much more helpful error message.
|
I cannot evaluate changes in the production code, it looks like a magic and a mud of ball at the same time to me. Considering that you have added new tests for the stuff you are fixing and all existing tests are passing, the patch LGTM as far as I am concerned. |
|
@bajtos LOL, I thought it was a ball of mud too before finally giving up and asking @raymondfeng for help. ;) Glad I wasn't the only one. |
raymondfeng
added a commit
that referenced
this pull request
Mar 2, 2015
Make sure inclusion filter is applied to the target model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/to @ritch or @bajtos
/cc @superkhau
The PR ensures the scope on
includeis applied to the target model instead of the through model.See strongloop/loopback#1076