Modify query tests to fix failures (v4) #1811
Conversation
markdirish
requested review from
b-admike,
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
There was a problem hiding this comment.
@markdirish Thank you for the contribution! Would it make more sense to do the string conversion in loopback-connector-ibmi instead of in the test? Otherwise the code changes LGTM.
| // every name beginning with a capital letter, and the test will fail. | ||
| let compareString = 'xyz'; | ||
| if (db.adapter.name === 'ibmi') { // i.e. "if EBCDIC encoding" | ||
| compareString = 'XYZ'; |
There was a problem hiding this comment.
Does it make more sense to do the conversion in loopback-connector-ibmi?
| @@ -653,7 +663,7 @@ describe('basic-querying', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('geo queries', function() { | |||
| bdd.describeIf(connectorCapabilities.geoPoint, 'geo queries', function() { | |||
There was a problem hiding this comment.
The comment #1810 (comment) is applicable to this pull request too. Let's discuss the matter in the other PR first, and then apply the conclusions here.
Hmm, I believe we are intentionally testing geo queries for all connectors, including those that don't provide native GeoPoint & near query support. IIRC, when the connector does not implement near queries, juggler will perform the search in memory.
Take
db2anddashdbfor an example. According to the check on the line 52 above, these connectors don't support GeoPoint type, yet they still pass alldescribe('geo queries')tests.Let's find a way how to allow the
ibmiconnector pass these test too.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
Several
basic-querying.test.jstests fail when running withloopback-connector-ibmi. Explanations can be found in issue #1809. This PR fixes the tests on v3 (LTS) branch.Part of #1809
Checklist
npm testpasses on your machine