fix: prevent max listeners warning #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emonddr
requested review from
b-admike,
dhmlau,
jannyHou and
zbarbuto
as code owners
emonddr
force-pushed
the
dremond_migrate_errors
branch
from
afdc19b to
797387e
Compare
raymondfeng
reviewed
Aug 1, 2019
raymondfeng
reviewed
Aug 1, 2019
nabdelgadir
force-pushed
the
dremond_migrate_errors
branch
from
bdeffdc to
133da87
Compare
2 tasks
nabdelgadir
force-pushed
the
dremond_migrate_errors
branch
from
133da87 to
fc10a11
Compare
raymondfeng
reviewed
Aug 2, 2019
raymondfeng
reviewed
Aug 2, 2019
raymondfeng
reviewed
Aug 2, 2019
nabdelgadir
force-pushed
the
dremond_migrate_errors
branch
2 times, most recently
from
487957a to
bb311a7
Compare
jannyHou
approved these changes
Aug 8, 2019
LGTM just a nitpick for the test.
dhmlau
approved these changes
Aug 8, 2019
nabdelgadir
force-pushed
the
dremond_migrate_errors
branch
from
bb311a7 to
39ebf88
Compare
If establishing a database connection is slow and database migration runs and there are many models, sql operations are queued up and this leads to the node.js max emitters exceeded warning. A default value for max emitters has now been introduced, and it can also be configured in datasources.json. Co-authored-by: Dominique Emond <[email protected]>
nabdelgadir
force-pushed
the
dremond_migrate_errors
branch
from
39ebf88 to
bca6315
Compare
This was referenced Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If establishing a database connection is slow and database migration runs and there are many models, sql operations are queued up and this leads to the node.js max emitters exceeded warning.
A default value for max emitters has now been introduced, and it can also be configured in datasources.json.
Related issues
Checklist