fix: report errors from automigrate/autoupdate (defer automigrate/autoupdate until we are connected) #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
b-admike,
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
1 task
hacksparrow
reviewed
Jul 2, 2019
hacksparrow
approved these changes
Jul 2, 2019
bajtos
force-pushed
the
fix/migrate-errors
branch
2 times, most recently
from
016dd58 to
dea001f
Compare
b-admike
approved these changes
Jul 4, 2019
Defer automigrate/autoupdate until we are connected, so that connection errors can be reported back to callers. Fix postInit handler to not report connection error to console.log and via dataSource "error" event in case there is already an operation queued. When this happens, we want the error to be handled by the queued operation and reported to its caller. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
fix/migrate-errors
branch
from
dea001f to
40286fc
Compare
|
@slnode test please |
bajtos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer automigrate/autoupdate until we are connected, so that connection errors can be reported back to callers.
Fix
postInithandler to not report connection error toconsole.logand via dataSource "error" event in case there is already an operation queued. When this happens, we want the error to be handled by the queued operation and reported to its caller.Related issues
Checklist
guide