Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update copyrights years #1737

Merged
merged 1 commit into from
May 8, 2019
Merged

chore: update copyrights years #1737

merged 1 commit into from
May 8, 2019

Conversation

agnes512
Copy link
Contributor

@agnes512 agnes512 commented May 7, 2019

Description

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

dhmlau
dhmlau approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed through the changes. LGTM.

@dhmlau
Copy link
Member

dhmlau commented May 7, 2019

@b-admike , are you aware of this downstream failure in postgresql? Thanks.

@b-admike
Copy link
Contributor

b-admike commented May 8, 2019

@slnode test please

@b-admike
Copy link
Contributor

b-admike commented May 8, 2019

The downstream postgresql build failure might be because of a messy db state:

  1 failing
14:14:47 
14:14:47   1) autoupdate
14:14:47        foreign key constraint
14:14:47          should create, update, and delete foreign keys:
14:14:47      error: duplicate key value violates unique constraint "pg_namespace_nspname_index" (while running initial autoupdate)
14:14:47       at Connection.parseE (node_modules/pg/lib/connection.js:601:11)
14:14:47       at Connection.parseMessage (node_modules/pg/lib/connection.js:398:19)
14:14:47       at Socket.<anonymous> (node_modules/pg/lib/connection.js:120:22)
14:14:47       at readableAddChunk (_stream_readable.js:176:18)
14:14:47       at Socket.Readable.push (_stream_readable.js:134:10)
14:14:47       at TCP.onread (net.js:559:20)
14:14:47 
14:14:47 
14:14:47 
14:14:47

re-running the builds.

b-admike
b-admike suggested changes May 8, 2019
View reviewed changes
lib/connectors/transient.js
@@ -1,4 +1,4 @@
// Copyright IBM Corp. 2014,2016. All Rights Reserved.
// Copyright IBM Corp. 2014,2018. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rationale behind some of the updates being 2018 and others 2019?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it indicates the last time the file was being updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fair enough. Are we using a script to do the updates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b-admike FYI - the first "year" in the copyright statement is the year that this file was created, 2nd "year" is the year that the file was last updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. But some part of it need to be fixed manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yes, we're running strong-tools slt copyright command.

b-admike
b-admike approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhmlau dhmlau merged commit de4718d into master May 8, 2019
@dhmlau dhmlau deleted the copyrights branch May 8, 2019 15:45
bajtos added a commit that referenced this pull request May 14, 2019
@bajtos
4.7.1
a5ba740 
 * Fix "access" hook for unoptimized "near" queries (Miroslav Bajtoš)
 * Fix "loaded" hook for unoptimized "near" queries (Miroslav Bajtoš)
 * Test "near" queries executed in memory (Miroslav Bajtoš)
 * Fix DateString ctor to accept DateString instances (Miroslav Bajtoš)
 * datasource: copy settings object in constructor (Miroslav Bajtoš)
 * chore: update copyrights years (#1737) (Agnes Lin)
 * chore: update LTS status (#1734) (Diana Lau)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@b-admike b-admike b-admike approved these changes

@emonddr emonddr Awaiting requested review from emonddr

@jannyHou jannyHou Awaiting requested review from jannyHou

@zbarbuto zbarbuto Awaiting requested review from zbarbuto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agnes512 @dhmlau @b-admike @nabdelgadir