fix: update typescript declarations #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-admike
requested review from
dhmlau,
jannyHou,
virkt25 and
zbarbuto
as code owners
7 tasks
bajtos
reviewed
Nov 5, 2018
| @@ -154,7 +154,7 @@ export declare class PersistedModel extends ModelBase { | |||
| data: PersistedData, | |||
| options?: Options, | |||
| callback?: Callback<PersistedModel>, | |||
| ): PromiseOrVoid<PersistedModel>; | |||
| ): PromiseOrVoid<[PersistedModel, boolean]>; | |||
jannyHou
approved these changes
Dec 6, 2018
|
@b-admike what's the status of this pull request? Can you rebase it on top of the latest master, fix Travis CI build and get it landed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix return type of PersistedModel's
findOrCreatefunction so that it conforms to the return contract of connectors which support it (took mongodb and memory as examples). Also, add a string index signature to theConnectorinterface to allow checks for atomic functions.Connect to loopbackio/loopback-next#1956.
Checklist
guide