Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] validations: support non-V8 browsers #152

Merged
merged 1 commit into from
Jun 24, 2014

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 23, 2014

Call Error.captureStackTrace() only when it is available.

Use this.stack = (new Error).stack when captureStackTrace is not
available but the stack property is (Firefox).

/to @ritch please review.

Call `Error.captureStackTrace()` only when it is available.

Use `this.stack = (new Error).stack` when `captureStackTrace` is not
available but the `stack` property is (Firefox).
@bajtos bajtos changed the title validations: support non-V8 browsers [2.0] validations: support non-V8 browsers Jun 23, 2014
@ritch
Copy link
Contributor

ritch commented Jun 23, 2014

👍

bajtos added a commit that referenced this pull request Jun 24, 2014
…-browsers

[2.0] validations: support non-V8 browsers
@bajtos bajtos merged commit 89fbf16 into 2.0 Jun 24, 2014
@bajtos bajtos deleted the fix-validation-error-stack-in-browsers branch June 24, 2014 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants