create sequence for nosql id #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-admike
approved these changes
Apr 25, 2017
dhmlau
approved these changes
Apr 25, 2017
jannyHou
force-pushed
the
fix/relation-test
branch
4 times, most recently
from
29e47ba to
80acca7
Compare
dhmlau
reviewed
Apr 27, 2017
test/basic-querying.test.js
Outdated
| users[0].name.should.equal('John Lennon'); | ||
| users[1].name.should.equal('Paul McCartney'); | ||
| var expectedNames = ['John Lennon', 'Paul McCartney']; | ||
| expectedNames.indexOf(users[0].name).should.be.above(-1); |
There was a problem hiding this comment.
I guess we're checking the index is not -1... would it be should.not.equal(-1)?
test/relations.test.js
Outdated
| // mongodb returns `id` as an object | ||
| idArr[0] = idArr[0].toString(); | ||
| idArr[1] = idArr[1].toString(); | ||
| idArr.indexOf(ch[0].id.toString()).should.be.above(-1); |
There was a problem hiding this comment.
same comment.. if we're checking index should not be -1, perhaps better to use should.not.equal(-1).
|
@dhmlau thanks applied. |
b-admike
approved these changes
Apr 27, 2017
jannyHou
force-pushed
the
fix/relation-test
branch
2 times, most recently
from
b0ab6e3 to
c1e2095
Compare
jannyHou
force-pushed
the
fix/relation-test
branch
from
c1e2095 to
23f1856
Compare
kjdelisle
pushed a commit
that referenced
this pull request
May 2, 2017
* create sequence for nosql id (#1354) (Janny) * Fix order of query results (Loay) * Add DateString type (Kevin Delisle) * datatype.test: use predefined date (Kevin Delisle) * Update api documents (Loay) * Datasource documentation tune-up (Kevin Delisle) * Added unit tests specific to DateType where null (#1349) (Andrew McDonnell) * Fix/geo null (#1334) (paulussup) * replace exception thrown for invalid dates (Diana Lau) * Revert PR #1326 (#1336) (Sakib Hasan) * Make lib peerDepend on loopback-connector (#1326) (Russ Tyndall) * Add test case using updateAttributes (Loay) * Fix forceId bug for updateOrCreate (Loay) * Fix typo in description (jannyHou) * Fix relations test case (loay)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR created when recovering test cases in cloudant:
cloudant creates string type id which could not guarantee id are incremented. To solve the problem, I add a
sequenceproperty to make sure the related test case returns result ordered by sequence and will skip the first data.Checklist
guide