-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Model.count base implementation and Normalize/validate the query filter #130
Conversation
* @param {Object} filter The query filter object | ||
* @returns {Object} The normalized filter object | ||
* @private | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best way for documenting private methods is to use
/**
* (...)
* @private
*/
That way IDEs like WebStorm can use the type information provided by jsdoc (thanks to /**
), but the documentation is discarded by strong-docs (thanks to @private
).
Comments starting with /*!
are usually used for license boilerplate that should be preserved by minifiers in the output bundle.
Makes sense. Could you please review/approve loopbackio/loopback-connector#2 and submit a pull request with the changes you made to BTW #127 is going delete |
@@ -999,10 +1077,11 @@ setRemoting(DataAccessObject.prototype.updateAttributes, { | |||
http: {verb: 'put', path: '/'} | |||
}); | |||
|
|||
/** | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required to remove from strong-docs? I'm pretty sure @private
is supported.
Minor comments from me. Otherwise looks good 👍. |
Fix Model.count base implementation and Normalize/validate the query filter
The PR fixes two issues:
/to @ritch
/to @bajtos (We'll need to merge them into the loopback-connector repo).