Skip to content

Commit

Permalink
chore: reduce identifier length
Browse files Browse the repository at this point in the history
Existing identifier length exceeds Oracle DB's limit.
  • Loading branch information
Hage Yaapa committed Sep 4, 2019
1 parent 8134830 commit 516499d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions test/basic-querying.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1103,11 +1103,12 @@ describe('basic-querying', function() {
dateProp: Date,
numProp: Number,
});
numAndDateArrayModel = db.define('numAndDateArrayModel', {
// 'numAndDateArrayModel' is too long an identifier name for Oracle DB
numAndDateArrayModel = db.define('numAndDateArrMod', {
dateArray: [Date],
numArray: [Number],
});
return db.automigrate(['numAndDateModel', 'numAndDateArrayModel']);
return db.automigrate(['numAndDateModel', 'numAndDateArrMod']);
});

it('coerces primitive datatypes on update', function() {
Expand Down
5 changes: 3 additions & 2 deletions test/datatype.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ describe('datatypes', function() {
nested: Nested,
};
Model = db.define('Model', modelTableSchema);
modelWithDecimalArray = db.define('modelWithDecimalArray', {
// 'modelWithDecimalArray' is too long an identifier name for Oracle DB
modelWithDecimalArray = db.define('modelWithDecArr', {
randomReview: {
type: [String],
mongodb: {
Expand All @@ -42,7 +43,7 @@ describe('datatypes', function() {
numArrayModel = db.define('numArrayModel', {
bunchOfNums: [Number],
});
db.automigrate(['Model', 'modelWithDecimalArray', 'dateArrayModel', 'numArrayModel'], done);
db.automigrate(['Model', 'modelWithDecArr', 'dateArrayModel', 'numArrayModel'], done);
});

it('should resolve top-level "type" property correctly', function() {
Expand Down

0 comments on commit 516499d

Please sign in to comment.