fix: return auto-increment as generated #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
fix/return-auto-increment
branch
from
7c70abe to
4e05e55
Compare
Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
fix/return-auto-increment
branch
from
fe576c5 to
35030cd
Compare
aaqilniz
requested review from
dhmlau,
achrinza and
marioestradarosa
as code owners
samarpanB
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version of Postgres, we can have the id as auto-increment by adding an identity constraint with the value set to ALWAYS. This PR enables the connector to return the
generatedas true if a column is set to be an auto-increment with this constraint.Checklist
npm testpasses on your machine