Remove peer dependency on datasource-juggler #28
Conversation
|
Test Failed. To trigger a build add comment - ".test\W+please" |
|
The build if failing because /cc @rmg |
|
test please |
|
All is well |
| // loopback-datasource-juggler 1.x | ||
| modelBuilder.constructor.registerType.bind(modelBuilder.constructor); | ||
|
|
||
| defineType(function Point() { |
|
Not sure why we are defining an empty |
I assume Perhaps @raymondfeng can provide more details? |
|
The Point type is inherited from jugglingdb mysql adapter. Now we have GeoPoint. The Point type is not used. We can remove it at some point. |
Use `SqlConnector` from loopback-connector as the base class for the MySQL connector. Use `dataSource.modelBuilder` instead of `juggler.ModelBuilder` to access the function for registering new schema type. Note: the behaviour remains backwards compatible, the connector can be used with both old 1.x and upcoming 2.x versions of loopback-datasource-juggler.
|
Added a comment explaining where is |
Remove peer dependency on datasource-juggler
Use
SqlConnectorfrom loopback-connector as the base class for theMySQL connector.
Use
dataSource.modelBuilderinstead ofjuggler.ModelBuildertoaccess the function for registering new schema type.
Note: the behaviour remains backwards compatible, the connector can be
used with both old 1.x and upcoming 2.x versions of
loopback-datasource-juggler.
Requires loopbackio/loopback-connector#2.
/to @raymondfeng @ritch please review
strongloop/loopback#275