Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Node.js 10 support #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: drop Node.js 10 support #241

wants to merge 1 commit into from

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Nov 29, 2021

Signed-off-by: Diana Lau [email protected]

Node.js 10 has reached EOL April 2020, see https://nodejs.org/en/about/releases/.
We're dropping the support for Node.js 10.

Note: We need to get GitHub Actions working for CI. I'm running tests locally for now.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

Copy link

@marioestradarosa marioestradarosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!. As for the keywords, do we have a standard way from now on for these packages (ie: loopbackio) ?.

@dhmlau
Copy link
Member Author

dhmlau commented Nov 29, 2021

@marioestradarosa, I wasn't intended to update the keywords, since it has LoopBack in it. But I'm open for suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants