Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regexp on like/nlike operator #378

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

ssh24
Copy link
Contributor

@ssh24 ssh24 commented Jun 20, 2017

Description

Allow the user to specify the regexp on a like or nlike operator in different forms other than just string and then letting our mongodb ORM creating the RegExp object. This feature shall allow the user to filter using like and nlike operator using different forms of regexp:

  • regexp as a string (i.e '^H.')
  • regexp as a literal (i.e /^H/)
  • regexp as an object (i.e new RegExp(/^H/))

connect to #151

@ssh24
Copy link
Contributor Author

ssh24 commented Jun 21, 2017

@slnode test please

1 similar comment
@ssh24
Copy link
Contributor Author

ssh24 commented Jun 21, 2017

@slnode test please

Copy link
Contributor

@loay loay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

As a regexp string
As a regexp literal
As a regexp object
@ssh24 ssh24 force-pushed the feature/allow-regexp-on-like-operator branch from ac67b30 to 3e24854 Compare June 21, 2017 19:19
@ssh24 ssh24 merged commit e7c8787 into master Jun 21, 2017
@ssh24 ssh24 deleted the feature/allow-regexp-on-like-operator branch June 21, 2017 19:48
@ssh24 ssh24 removed the #review label Jun 21, 2017
@ssh24 ssh24 added this to the Sprint 38 - Apex milestone Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants