Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update environment #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: update environment #63

wants to merge 1 commit into from

Conversation

achrinza
Copy link
Member

  • test against Node.js v16,v17,v18
  • test against Redis v7
  • test against alternate architectures

see: loopbackio/cicd#2
see: loopbackio/cicd#27
Signed-off-by: Rifa Achrinza [email protected]

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@achrinza
ci: update environment
e101a15 
- test against Node.js v16,v17,v18
- test against Redis v7
- test against alternate architectures

see: loopbackio/cicd#2
see: loopbackio/cicd#27
Signed-off-by: Rifa Achrinza <[email protected]>
dhmlau
dhmlau approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might want to add the code linter and commit linter as well. But I'm good to leave it for a separate PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achrinza @dhmlau