Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] test Node.js 14 #82

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] test Node.js 14 #82

wants to merge 1 commit into from

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Oct 2, 2020

Signed-off-by: Diana Lau [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@dhmlau
test Node.js 14
82f042b 
Signed-off-by: Diana Lau <[email protected]>
@dhmlau dhmlau requested a review from jannyHou as a code owner October 2, 2020 18:36
@dhmlau
Copy link
Member Author

dhmlau commented Oct 2, 2020

@slnode test please

@dhmlau dhmlau mentioned this pull request Oct 4, 2020
Closed
4 tasks
@dhmlau
Copy link
Member Author

dhmlau commented Oct 4, 2020

It's verified that CI works on Node.js 14. Closing this PR.

@dhmlau dhmlau closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhmlau