1.x fix/upsert #129
Merged
1.x fix/upsert #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2017
Closed
ssh24
approved these changes
May 10, 2017
dhmlau
approved these changes
May 10, 2017
|
@slnode test please |
Amir-61
reviewed
May 10, 2017
test/cloudant.test.js
Outdated
| afterEach(function(done) { | ||
| Product.destroyById(1, function(err) { | ||
| if (err) return done(err); | ||
| done(); |
There was a problem hiding this comment.
Instead of:
function(err) {
if (err) return done(err);
done();
}
Just the following line is enough:
done(err)
test/cloudant.test.js
Outdated
| if (err) return done(err); | ||
| res.id.should.equal('1'); | ||
| res.name.should.equal('bread'); | ||
| // scenario: upsert does a update |
test/cloudant.test.js
Outdated
| Product.upsert({ | ||
| id: '1', | ||
| name: 'newBread', | ||
| }, function(err, res) { |
test/cloudant.test.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('can call upsert with an id and have it create a document without error', |
There was a problem hiding this comment.
Probably the following is what you are achieving here:
can call upsert with a primary key and create/update a document without error
Also it is always a good idea if you try primary keys which are not id as well.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #111