Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a week of meals #40

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Display a week of meals #40

merged 2 commits into from
Jul 26, 2024

Conversation

marionbarker
Copy link
Contributor

Provide an entire week of ICE (meal) display.

This customization is based on

The test method while in the feature branch is found in the lnl-script PR 62: Display a week of meals

Copy link

@oliverstory oliverstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity if you want to change the name of the previousMidnight variable, I suggest changing to earliestMidnight (lines 24 and 34, and referred to in the comment on line 33)

Otherwise it looks good.

@marionbarker marionbarker requested a review from bjorkert July 26, 2024 13:00
Copy link
Contributor

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marionbarker marionbarker merged commit f07f0ea into dev Jul 26, 2024
@marionbarker marionbarker deleted the meal_week branch July 27, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants