Add ability to use LoomProvider with the /eth endpoint #299

redben · 2019-08-15T11:35:41Z

No description provided.

# Conflicts: # e2e_tests.sh

src/helpers.ts

src/tests/helpers.ts

src/tests/e2e_tests.ts

src/tests/e2e/loom-provider-web3-tests.ts

src/loom-provider.ts

src/client.ts

src/internal/ws-rpc-client.ts

src/client.ts

- remove Client.readClient - Client.sendWeb3MsgAsync - Client.sendWeb3MsgAsync revert code in getevmfilterchanges - update LoomProvider accordingly

src/helpers.ts

src/tests/e2e/loom-provider-web3-tests.ts

- ClientEvent.EVMEvent - catch on test - readerSuffix

(.blockNumber does not seem to be used by web3, keeping it there to not break stuff)

redben · 2019-08-28T18:37:38Z

One test still fails... didn't we disable blueprint?

Calls via HTTP

contractAddr = await client.getContractAddressAsync('BluePrint')
>> Error: Failed to resolve contract address

Just to test that we didn't break interaction with Go contracts. BluePrint will get replaced by the SampleGoContract in the near future.

This reverts commit cebfaa2.

enlight · 2019-09-24T18:14:47Z

This is an intermediate step that will allow us to start using the Web3 JSON-RPC methods provided by Loom nodes on the /eth endpoint. The end goal is to switch over to a completely new version of LoomProvider that's being built in #303 but that still requires some work in loomchain, as well as extensive testing.

One annoying limitation of the changes in this PR is that a single Client instance can't be used to interact with both the /eth and /query endpoints, so any one Client instance can only interact with EVM contracts, or Go contracts, but not both at once.

enlight

LGTM

redben and others added 9 commits August 15, 2019 18:30

Expose read client

1a39fc2

Change reader suffix to /eth

8161b7c

Forward rpc static calls as is to /eth endpoint

1acee64

format

8b9dcd0

Fix _ethCallSupportedMethod return type

5183ef4

e2e wip

62c5f31

Don't deploy blueprint contract

8d8ce5c

Merge branch 'disable-blueprint' into loom-provider-eth-endpoint

b6918fe

# Conflicts: # e2e_tests.sh

Keep support for old protocol in client and loomProvider

80fa6d0

redben marked this pull request as ready for review August 20, 2019 13:30

redben added 3 commits August 20, 2019 20:38

ws-rpc-client id string/number bug workaround

a5192b6

revert changes to e2e_tests.ts

085b054

format

bffb4c3

redben commented Aug 21, 2019

View reviewed changes

src/helpers.ts Outdated Show resolved Hide resolved

redben added 3 commits August 21, 2019 14:14

Fix loomProvider _ethRPCMethods subscribe/unsubscribe

5dc2706

LoomProvider keep support of old protocol in _onWebSocketMessage

75a68bc

ws-rpc-client._onEventMessage: add back event handling for old endpoint

7b84d8f

enlight requested changes Aug 21, 2019

View reviewed changes

redben added 2 commits August 21, 2019 17:40

Address PR comments

8719dcc

- remove Client.readClient - Client.sendWeb3MsgAsync - Client.sendWeb3MsgAsync revert code in getevmfilterchanges - update LoomProvider accordingly

WSRPCClient keep original interface (protected _getNextRequestId)

2263779

enlight requested changes Aug 22, 2019

View reviewed changes

src/helpers.ts Outdated Show resolved Hide resolved

src/tests/e2e/loom-provider-web3-tests.ts Outdated Show resolved Hide resolved

redben and others added 9 commits August 22, 2019 17:26

LoomProvider: Remove unused imports

d68aa3b

Address comments on PR

291771d

- ClientEvent.EVMEvent - catch on test - readerSuffix

Cleanup

0d728a2

Fix the build?

87994b7

Run web3 tests against /queryws & /eth endpoints (where it makes sense)

6df71f8

Fix .number in loomProvider._createBlockInfo

d7f7685

(.blockNumber does not seem to be used by web3, keeping it there to not break stuff)

LoomProvider Web3: Fix events

61e0cff

LoomProvider._onWebSocketMessage fix conditional paths

5a22b37

Move call _client.addListenerForTopics()) to the right place

094d2df

Skip BluePrint contract test

5f2d002

redben requested a review from enlight August 29, 2019 16:26

enlight added 11 commits August 30, 2019 19:45

Bring back BluePrint

f79c244

Just to test that we didn't break interaction with Go contracts. BluePrint will get replaced by the SampleGoContract in the near future.

Cleanup

21f7c13

Fix build error

a8f2fdb

Make WSRPCClient handle all EVM notifications regardless of the endpoint

a36280e

/eth endpoint supports eth_getBalance

2d8bc4b

The good old change shit until it works approach

cebfaa2

Switch on logging

4fee498

Upgrade to build 1283

50201d7

Update loom binary download location

478f32f

Revert "The good old change shit until it works approach"

3f0dcf9

This reverts commit cebfaa2.

Better naming for tests & some more cleanup

b0d6752

enlight changed the title ~~Loom provider eth endpoint~~ Add ability to use LoomProvider with the Loom /eth endpoint Sep 24, 2019

enlight changed the title ~~Add ability to use LoomProvider with the Loom /eth endpoint~~ Add ability to use LoomProvider with the /eth endpoint Sep 24, 2019

Switch off logging

c466082

enlight approved these changes Sep 24, 2019

View reviewed changes

enlight merged commit 1123281 into master Sep 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to use LoomProvider with the /eth endpoint #299

Add ability to use LoomProvider with the /eth endpoint #299

redben commented Aug 15, 2019

redben commented Aug 28, 2019 •

edited

Loading

enlight commented Sep 24, 2019

enlight left a comment

Add ability to use LoomProvider with the /eth endpoint #299

Add ability to use LoomProvider with the /eth endpoint #299

Conversation

redben commented Aug 15, 2019

redben commented Aug 28, 2019 • edited Loading

enlight commented Sep 24, 2019

enlight left a comment

Choose a reason for hiding this comment

redben commented Aug 28, 2019 •

edited

Loading