Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing API 3.x references from sdk-codegen to unblock 23.18 release #1399

Merged
merged 22 commits into from
Nov 22, 2023

Conversation

deanlooker
Copy link
Contributor

Testing changes to run CI

Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 9ff2b94.

Copy link
Contributor

Typescript Tests

0 files   -     6  0 suites   - 60   0s ⏱️ - 11m 48s
0 tests  - 229  0 ✔️  - 225  0 💤  -   4  0 ❌ ±0 
0 runs   - 552  0 ✔️  - 536  0 💤  - 16  0 ❌ ±0 

Results for commit 9ff2b94. ± Comparison against base commit 3ea3cfc.

This pull request removes 229 tests.
AccessToken defaults with empty token ‑ AccessToken defaults with empty token
AccessToken has a 10 second lag time for expiration ‑ AccessToken has a 10 second lag time for expiration
AccessToken is active with full token ‑ AccessToken is active with full token
ApiMethods full path with auth is just full path ‑ ApiMethods full path with auth is just full path
ApiMethods full path without auth is just full path ‑ ApiMethods full path without auth is just full path
ApiMethods path not prefixed if base url not set ‑ ApiMethods path not prefixed if base url not set
ApiMethods relative path with auth is api path ‑ ApiMethods relative path with auth is api path
ApiMethods relative path without auth is just base ‑ ApiMethods relative path without auth is just base
Browser session authenticate causes authentication ‑ Browser session authenticate causes authentication
Browser session getToken is mocked ‑ Browser session getToken is mocked
…

Copy link
Contributor

Go Tests

    6 files      6 suites   5m 54s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 9ff2b94.

Copy link
Contributor

Codegen Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 9ff2b94.

Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 9ff2b94.

Copy link
Contributor

APIX Tests

    1 files    88 suites   7m 57s ⏱️
420 tests 388 ✔️ 26 💤 6 ❌
442 runs  410 ✔️ 26 💤 6 ❌

For more details on these failures, see this check.

Results for commit fea6346.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   2m 37s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit fea6346.

Copy link
Contributor

Go Tests

    6 files      6 suites   7m 49s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit fea6346.

Copy link
Contributor

Typescript Tests

    6 files  ±  0    60 suites  ±0   9m 25s ⏱️ - 2m 23s
227 tests  -   2  219 ✔️  -   6    4 💤 ±0  4 ❌ +4 
540 runs   - 12  520 ✔️  - 16  16 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit fea6346. ± Comparison against base commit 3ea3cfc.

This pull request removes 2 tests.
extension_sdk tests creates 31 client ‑ extension_sdk tests creates 31 client
extension_sdk tests creates exclusive 31 client ‑ extension_sdk tests creates exclusive 31 client

Copy link
Contributor

Go Tests

    6 files      6 suites   6m 10s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 5680b8c.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   3m 33s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit 5680b8c.

Copy link
Contributor

Typescript Tests

    6 files  ±  0    60 suites  ±0   7m 29s ⏱️ - 4m 19s
227 tests  -   2  223 ✔️  -   2    4 💤 ±0  0 ❌ ±0 
540 runs   - 12  524 ✔️  - 12  16 💤 ±0  0 ❌ ±0 

Results for commit 5680b8c. ± Comparison against base commit 3ea3cfc.

This pull request removes 2 tests.
extension_sdk tests creates 31 client ‑ extension_sdk tests creates 31 client
extension_sdk tests creates exclusive 31 client ‑ extension_sdk tests creates exclusive 31 client

Copy link
Contributor

APIX Tests

    1 files    88 suites   7m 50s ⏱️
420 tests 392 ✔️ 26 💤 2 ❌
442 runs  414 ✔️ 26 💤 2 ❌

For more details on these failures, see this check.

Results for commit 5680b8c.

@deanlooker deanlooker changed the title API 3.x Removal - Testing changes Removing API 3.x references from sdk-codegen to unblock 23.18 release Nov 15, 2023
Copy link
Contributor

Go Tests

    6 files      6 suites   6m 10s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 5ddb1c9.

Copy link
Contributor

Python Tests

    8 files      8 suites   2s ⏱️
144 tests 117 ✔️   3 💤 0 ❌ 24 🔥
652 runs  570 ✔️ 10 💤 0 ❌ 72 🔥

For more details on these errors, see this check.

Results for commit 5ddb1c9.

Copy link
Contributor

APIX Tests

    1 files    89 suites   8m 49s ⏱️
426 tests 394 ✔️ 32 💤 0 ❌
448 runs  416 ✔️ 32 💤 0 ❌

Results for commit 5ddb1c9.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   2m 44s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit 5ddb1c9.

Copy link
Contributor

Python Tests

    4 files      4 suites   1s ⏱️
120 tests 116 ✔️ 3 💤 1 ❌
464 runs  453 ✔️ 8 💤 3 ❌

For more details on these failures, see this check.

Results for commit e4578ea.

Copy link
Contributor

Go Tests

    6 files      6 suites   5m 56s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit e4578ea.

Copy link
Contributor

APIX Tests

    1 files    89 suites   8m 29s ⏱️
426 tests 394 ✔️ 32 💤 0 ❌
448 runs  416 ✔️ 32 💤 0 ❌

Results for commit e4578ea.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   3m 25s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit e4578ea.

Copy link
Contributor

Typescript Tests

    6 files  ±  0    60 suites  ±0   9m 20s ⏱️ - 2m 28s
227 tests  -   2  223 ✔️  -   2    4 💤 ±0  0 ❌ ±0 
540 runs   - 12  524 ✔️  - 12  16 💤 ±0  0 ❌ ±0 

Results for commit e4578ea. ± Comparison against base commit 3ea3cfc.

This pull request removes 2 tests.
extension_sdk tests creates 31 client ‑ extension_sdk tests creates 31 client
extension_sdk tests creates exclusive 31 client ‑ extension_sdk tests creates exclusive 31 client

Copy link
Contributor

Go Tests

    6 files      6 suites   6m 2s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 2989ec5.

Copy link
Contributor

Python Tests

    7 files      7 suites   57s ⏱️
144 tests 139 ✔️   4 💤 1 ❌
628 runs  611 ✔️ 15 💤 2 ❌

For more details on these failures, see this check.

Results for commit 2989ec5.

Copy link
Contributor

APIX Tests

    1 files    89 suites   8m 44s ⏱️
426 tests 394 ✔️ 32 💤 0 ❌
448 runs  416 ✔️ 32 💤 0 ❌

Results for commit 2989ec5.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   2m 35s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit 2989ec5.

Copy link
Contributor

Typescript Tests

    6 files  ±  0    60 suites  ±0   9m 3s ⏱️ - 2m 45s
227 tests  -   2  223 ✔️  -   2    4 💤 ±0  0 ❌ ±0 
540 runs   - 12  524 ✔️  - 12  16 💤 ±0  0 ❌ ±0 

Results for commit 2989ec5. ± Comparison against base commit 3ea3cfc.

This pull request removes 2 tests.
extension_sdk tests creates 31 client ‑ extension_sdk tests creates 31 client
extension_sdk tests creates exclusive 31 client ‑ extension_sdk tests creates exclusive 31 client

Copy link
Contributor

Go Tests

    6 files      6 suites   5m 53s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 5d93350.

Copy link
Contributor

APIX Tests

    1 files    89 suites   8m 34s ⏱️
426 tests 394 ✔️ 32 💤 0 ❌
448 runs  416 ✔️ 32 💤 0 ❌

Results for commit 5d93350.

Copy link
Contributor

Python Tests

    9 files      9 suites   2m 9s ⏱️
144 tests 139 ✔️   5 💤 0 ❌
676 runs  657 ✔️ 19 💤 0 ❌

Results for commit 5d93350.

Copy link
Contributor

Codegen Tests

    1 files    18 suites   3m 16s ⏱️
418 tests 400 ✔️ 18 💤 0 ❌

Results for commit 5d93350.

Copy link
Contributor

Typescript Tests

    6 files  ±  0    60 suites  ±0   9m 0s ⏱️ - 2m 48s
227 tests  -   2  223 ✔️  -   2    4 💤 ±0  0 ❌ ±0 
540 runs   - 12  524 ✔️  - 12  16 💤 ±0  0 ❌ ±0 

Results for commit 5d93350. ± Comparison against base commit 3ea3cfc.

This pull request removes 2 tests.
extension_sdk tests creates 31 client ‑ extension_sdk tests creates 31 client
extension_sdk tests creates exclusive 31 client ‑ extension_sdk tests creates exclusive 31 client

Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deanlooker deanlooker merged commit fa2488c into main Nov 22, 2023
45 checks passed
@deanlooker deanlooker deleted the api3xremoval branch November 22, 2023 18:46

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants