Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Icon refactor pre-patches #2030

Merged
5 commits merged into from
Mar 12, 2021
Merged

fix: Icon refactor pre-patches #2030

5 commits merged into from
Mar 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2021

This PR addresses some minor issues found around Icon usage so that the upcoming refactor of Icon can be as narrow as possible and hopefully reduce snapshot changes within the refactor itself to a bare-minimum for ease of review.

Changes contained here-in

  • Apply font properly to InputDateRange (and in so-doing FieldDateRange)
  • Add story coverage in preparation for new icon features (color controls)
  • Correct Icon positioning (remove inline-flex allows icons to not absorb line-height and instead sit properly vertically centered. This affects Status & DataTable snapshots.
  • Removed spurious x-large size test for Status (was HUUGE)

Requirements

Please check the following items are addressed in your pull request (or are not applicable)

  • a11y impact (FUTURE: Make aXe pass req'd for CI ✅)

Image snapshots (choose one)

  • yes
  • not applicable

Documentation updated (choose one)

  • yes
  • not applicable

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2030 (91afd59) into main (8e45200) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files         404      404           
  Lines        6704     6705    +1     
  Branches     2153     2153           
=======================================
+ Hits         6275     6276    +1     
  Misses        429      429           
Impacted Files Coverage Δ
.../src/Form/Inputs/InputDateRange/InputDateRange.tsx 98.68% <100.00%> (+<0.01%) ⬆️
packages/components/src/Icon/Icon.tsx 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e45200...91afd59. Read the comment docs.

Co-authored-by: Luke Bowerman <[email protected]>
@ghost ghost requested review from jhardy and mdodgelooker March 12, 2021 17:14
Copy link
Contributor

@mdodgelooker mdodgelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 776216b into main Mar 12, 2021
@ghost ghost deleted the luke/icon-pre-patches branch March 12, 2021 21:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant