Fix defect #24

GetSpecificMappingAsync under DD-WRT returns errorcode 402.
lontivero · Apr 21, 2015 · 4bad619 · 4bad619
1 parent 790b407
commit 4bad619
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/Open.Nat/Upnp/UpnpNatDevice.cs b/Open.Nat/Upnp/UpnpNatDevice.cs
@@ -196,8 +196,16 @@ public override async Task<Mapping> GetSpecificMappingAsync (Protocol protocol,
             }
             catch (MappingException e)
             {
-                if (e.ErrorCode !=  UpnpConstants.NoSuchEntryInArray) throw;
-                return null;
+                if (e.ErrorCode == UpnpConstants.NoSuchEntryInArray ) return null;
+
+                // DD-WRT Linux base router (and others probably) fails with 402-InvalidArgument 
+                // when no mapping is found in the mappings table
+                if (e.ErrorCode == UpnpConstants.InvalidArguments)
+                {
+                    NatDiscoverer.TraceSource.LogWarn("Router failed with 402-InvalidArgument. Mapping not found is assumed.");
+                    return null;
+                }
+                throw;
             }
         }