Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace invalidUser with badAttempt #132

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

MGatner
Copy link
Collaborator

@MGatner MGatner commented Nov 6, 2019

There are a few references to lang('Auth.invalidUser'), which doesn't exist. Rather than adding that string this PR replaces the references to the existing language string badAttempt, as it is generally better to be opaque about whether the user account exists or not on login attempts.

@lonnieezell
Copy link
Owner

I don't remember where I read it but somewhere in the last year or two I'd seen it suggested that being opaque doesn't actually aid security that much only serves to frustrate users.

I'm not finding that link at the moment, but I'm ok with making this change for now.

@lonnieezell lonnieezell merged commit 7a4bc5c into lonnieezell:develop Nov 6, 2019
@MGatner
Copy link
Collaborator Author

MGatner commented Nov 6, 2019

Gotcha. Well if you decide you want a separate "user not found" message that would be easy to add and change this back.

@MGatner MGatner deleted the invalid-user branch November 6, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants