Implement view layout #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. Seems heavy handed to pass in the entire config array to the view when the only thing needed is the layout. Would prefer passing in just the layout name. |
|
|
|
Oh it did? I guess I missed that. Probably fine then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplying a view layout via the config will allow users to wrap the default views in their own layout, rather than publishing out all the views just to change the style.
This might run amuck of view publishing (or rather, the current behavior post-publish) but I think it is a better solution for modules requiring views, so that only the views that really need updating are moved into app and the rest get updated with the package.
N.B. also updated Bootstrap and dependencies.