Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elements is an abiguous method name #23

Closed
lonnen opened this issue Oct 30, 2020 · 1 comment
Closed

elements is an abiguous method name #23

lonnen opened this issue Oct 30, 2020 · 1 comment

Comments

@lonnen
Copy link
Owner

lonnen commented Oct 30, 2020

Matklad suggests this is ambiguous and we should consider renaming to something like distinct_elements

de16931#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R274
@lonnen
Copy link
Owner Author

lonnen commented Nov 13, 2020

fwiw, Python's multiset lib uses distinct_elements

@lonnen lonnen closed this as completed Nov 13, 2020
@lonnen lonnen reopened this Nov 13, 2020
@lonnen lonnen closed this as completed Nov 19, 2020
lonnen added a commit that referenced this issue Nov 19, 2020
@lonnen
fixes #23 rename to
0bbe69f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lonnen