Remove some qtg_ indirection functions #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All code is now C++, the only valid reason to have functions with C linkage is to call external functions.
ui_init ui_main ui_exit
There's only one GUI for Freeciv21 and it's very good like this.
Merge it directly into the help text.
They were used for the C clients back in the days.
Both were trivial.
No longer used.
It's easier to read when unfolded into new QPixmap; pix->fill().
Use pixmap->width() and pixmap->height() instead.
We have operator delete.
This patch touches many lines but the changes are mechanical, in most cases it simply adjusts function prototypes and variable types.
There was no progress whatsoever on 3D support since this was added over 4 years ago.
lmoureaux
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of small (except one) commits that remove the indirection functions that were used to cross the C -> C++ border. The whole system has always been misguided (one can use C++ from within an
extern "C"function, linkage only affects the name mangling of theexternfunction).Since the PR touches a billion files in many places I'd like to merge this quickly.
There is no functional change.