Do more error checking in AutoRevision.cmake #876

lmoureaux · 2022-02-06T18:32:02Z

Every git command can fail, we need to take this into account.

Closes #875.

Every git command can fail, we need to take this into account. Closes longturn#875.

lmoureaux · 2022-02-06T18:33:31Z

jwrober · 2022-02-06T18:48:21Z

So its working here, but not in your fork? Do you have any tags in your fork?

jwrober · 2022-02-06T18:53:29Z

It also looks like the VERSION variable has some extra lf and chars in it

CMake Error at CMakeLists.txt:47 (project):
  VERSION "

  3.0.813141" format invalid.

Also merge the tag name mangling in one single place.

Do more error checking in AutoRevision.cmake

9acfbc9

Every git command can fail, we need to take this into account. Closes longturn#875.

lmoureaux requested a review from jwrober February 6, 2022 18:32

Strip whitespace out of FC21_REV_TAG harder

d4ec25f

Also merge the tag name mangling in one single place.

lmoureaux merged commit 99ff09f into longturn:master Feb 6, 2022

lmoureaux deleted the bugfix/autorevision branch February 6, 2022 20:10

Provide feedback