Fix build issue from alpha 10 #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwrober
force-pushed
the
bugfix/alpha10
branch
from
31b8cff to
1053f58
Compare
jwrober
force-pushed
the
bugfix/alpha10
branch
from
1053f58 to
f4b83e3
Compare
jwrober
force-pushed
the
bugfix/alpha10
branch
from
a4c552b to
184c39f
Compare
|
ok tested it in my fork, so should work now in master branch at next release time. |
|
Will you fix #853 in this PR or make another one? |
I'll go ahead and fix 853 here too. Good idea. |
|
Closes #853 |
|
Looks good to me. @zekoz can you check if it builds without git installed? |
|
I installed a fresh VM with Kubuntu 21.10 on it and installed the base packages needed to compile fc21 without So I think this patch does what we need it to. |
|
I could add some more message() to show what branch of the if() we are on. |
lmoureaux
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an explicit ref for the testing branch and removed it when initially pushed the PR for the auto tag work. Apparently it doesn't default to master branch as documented.