-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Revision #838
Auto Revision #838
Conversation
At this point I think this PR is close to ready. Need to figure out how to handle if |
Have a look at https://git-scm.com/docs/gitattributes#_export_subst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to test this, could you make a new branch in your fork and create a release there?
29600e5
to
fc51adb
Compare
One the tests complete, I think this PR is ready to merge. Only "issue" per se is the duplicate of the source tarball and zip at release time. We can point users to the defined assets in the release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought of yet another edge case 🔢
Will hopefully be easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's polish it once it hurts someone
This commit establishes the basics of getting some status from
git
and using that information when configuring and compiling freeciv21. Does not support the tagged tarball at this point. Right now this assumes you have a working repository andgit
installed.Eventually closes #444