Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in the UWT panel (F2) #800

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Fix bugs in the UWT panel (F2) #800

merged 2 commits into from
Jan 4, 2022

Conversation

lmoureaux
Copy link
Contributor

@lmoureaux lmoureaux commented Jan 2, 2022 •
edited
Loading

Closes #792.

Test plan:

  • /set unitwaittime 9999
  • Move a bunch of units (the more the better)
  • F2
  • Check that all items in the list can be seen by scrolling
  • Check that sorting by clicking on the headers works as expected

@jwrober
Copy link
Collaborator

jwrober commented Jan 3, 2022

I can do all but the last item. What is to be clicked as a "header"?

@lmoureaux
Copy link
Contributor Author

I can do all but the last item. What is to be clicked as a "header"?

The column names (for once, this uses a standard behavior).

jwrober
jwrober approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@lmoureaux lmoureaux merged commit 7df906d into longturn:master Jan 4, 2022
@lmoureaux lmoureaux deleted the bugfix/many-units-uwt branch January 4, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

@psampathkumar psampathkumar Awaiting requested review from psampathkumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client, UWT window adjustments
2 participants
@lmoureaux @jwrober