Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix colored menus on System Theme #756

Merged
merged 4 commits into from
Dec 5, 2021
Merged

Fix colored menus on System Theme #756

merged 4 commits into from
Dec 5, 2021

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Dec 3, 2021 •
edited
Loading

Closes #567

@jwrober
Copy link
Collaborator Author

jwrober commented Dec 3, 2021

When evaluating on Linux, test with a "dark mode" system theme such as Breeze Dark on KUbuntu.

@lmoureaux
Copy link
Contributor

This looks like NightStalker, not native Windows…
image

@lmoureaux
Copy link
Contributor

lmoureaux commented Dec 4, 2021 •
edited
Loading

Same issue when forcing the Plastic theme instead of the native Windows theme (Plastic is supposedly Qt's best maintained theme).

@lmoureaux
Copy link
Contributor

lmoureaux commented Dec 4, 2021 •
edited
Loading

Clearing everything from the stylesheet makes the menu look native (but obviously creates other issues).

The previous two comments only stand for Plastic.

lmoureaux
lmoureaux requested changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The black color for QLabel breaks dark themes badly (here Breeze Dark on Linux).

@jwrober jwrober requested a review from lmoureaux December 5, 2021 03:55
@jwrober
Copy link
Collaborator Author

jwrober commented Dec 5, 2021

I still ended up with the NightStalker menu look on all platforms, but it at least works now.

@psampathkumar
Copy link
Contributor

Maybe we should not use classic bg for the system theme.
image

GTK does something like this, and I think it is better
image

@jwrober jwrober merged commit 0ae09aa into longturn:master Dec 5, 2021
@jwrober jwrober deleted the theme_issue branch January 1, 2022 21:20
@lmoureaux lmoureaux mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psampathkumar psampathkumar Awaiting requested review from psampathkumar

@lmoureaux lmoureaux Awaiting requested review from lmoureaux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows System Theme black menu text hard to read
3 participants
@jwrober @lmoureaux @psampathkumar