Don't create a double 3.0 folder #694
Conversation
This reverts commit 2893571, which resulted in the creation of a double 3.0/3.0 directory. See longturn#660.
This makes it possible to install, for instance, a ruleset for different versions of Freeciv21 even though the files are not compatible. Closes longturn#660.
|
For something VERY cosmetic, it seems to be a bad idea to reduce/eliminate a feature of a program to "fix" something that does not really NEED fixing. If we are going to get rid of what "seems" to be a redundant directory then we should "fix" it and keep the modpack installer's ability to know what modpacks have been installed in the process. As written, this PR needs work before it should be merged into master branch. |
|
I'd be incited to add migration code it if we had had anything more stable than alpha releases. As it is it will only result in a minor annoyance for the few people who actually downloaded the alphas. I think the tradeoff between new code to maintain and annoyance is acceptable. If you want to migrate your metadata, it is sufficient to do (on Linux) |
|
I like the documentation idea as part of the release notes. I also agree about writing migration code if we were in a more stable release cycle. If a person decides to ignore the instructions, will the modpack installer create a new |
Yes. |
See #660.
As a side-effect of this PR, the modpack installer will "forget" which modpack versions are installed. Installed modpack will remain usable; installing them again merely overwrites the files.