Initial tileset debugger #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's going to interact quite a bit with the map view, make it a child of the view widget. See longturn#632.
The sprites drawn by each layer are shown. Offsets are not accounted for, and no reason is given for which sprites were selected. Some layers do not work (for instance, the grid); they probably require pedge or pcorner. See longturn#632.
This allows one to understand better what the layers are made of and how they works. See longturn#632.
The outline helps understand where sprites are drawn relative to each other. See longturn#632.
lmoureaux
force-pushed
the
feature/tileset-debugger
branch
from
aa5f0e6 to
4fc86a7
Compare
jwrober
reviewed
Sep 12, 2021
docs/Modding/Tilesets/debugger.rst
Outdated
| understand why something is rendering incorrectly or to understand how other | ||
| tilesets work. | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
Do we specifically need this note? Its pretty obvious we like suggestions.
There was a problem hiding this comment.
I wanted to emphasize this because the direction it takes in its early days will directly affect the quality of the end result (unless we rewrite it three times)
For consistency with other images, as pointed out by jwrober.
Better wording of the note, move the limitation to the main text. Also switch to "attention". See longturn#633.
Requrested by @jwrober.
lmoureaux
added a commit
that referenced
this pull request
Sep 12, 2021
Better wording of the note, move the limitation to the main text. Also switch to "attention". See #633.
psampathkumar
pushed a commit
to psampathkumar/freeciv21
that referenced
this pull request
Nov 14, 2021
Better wording of the note, move the limitation to the main text. Also switch to "attention". See longturn#633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #632. It's not quite perfect yet; in particular, only tile-based drawing is supported (as opposed to corner- and edge-based). Darkness is corner-based; grid and borders are edge-based.
It looks like this:
Built on top of #450 and helped understand a bug spotted there.