Fix inconsistent behavior when using view shortcuts #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `paintEvent(...)` on `top_bar_widget` instead of `QToolButton` paints the blue border when the button is active.
Reported by clangd.
An `if`-statement was missing, that was present in the other views. Unlike the over views, this condition checks `raise` to differentiate between calls to `science_report_dialog_popup` triggered by the user and the server. Without it, the Research View would be closed, for example, when the research goal is changed.
jwrober
approved these changes
Jan 7, 2025
Should work now. |
|
Wonderful! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2491.