Update build action to clang-format-17 #2457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwrober
changed the title
|
Ok, I think this is ready if we are good to stick with clang-format-17. Suggest a squash merge if approved. |
lmoureaux
reviewed
Dec 19, 2024
| @@ -106,7 +106,7 @@ On Linux, the easiest way to install KDevelop is with a command such as this: | |||
|
|
|||
| .. code-block:: sh | |||
|
|
|||
| $ sudo apt install kdevelop clang-format-11 | |||
| $ sudo apt install kdevelop clang-format-17 git-clang-format17 python3-sphinx | |||
There was a problem hiding this comment.
What's are the new minimum required distro versions? git-clang-format17 doesn't exist in Ubuntu 24.04 so I assume it's not in the 22.04 either.
We should update compile.rst accordingly. I'm not sure we want to bump requirements right before a release, so maybe this should come after 3.1?
|
Closing. Will re-do after we release 3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2. Closes #2417