Implement autoscroll for research tree #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The functionality is done, but I still want to use an icon for the QToolButtons. If someone who can handle Inkscape better and is a bit more talented than me would like to provide an icon, I would be grateful :) |
blabber
force-pushed
the
feature/autoscroll_techtree
branch
from
32c9126 to
67a946b
Compare
Allows the user to conveniently scroll the technology tree to the currently researched technology or the technology goal. A button next to the corresponding combo box is available to the user for this purpose. The icon used for the buttons is based on `crosshair-light` from Phosphor Icons with minor modifications to let it play nicely with our theming and to be recognizable on the small button.
blabber
force-pushed
the
feature/autoscroll_techtree
branch
from
67a946b to
c707c65
Compare
|
I added a slightly modified |
|
Closes #2365 |
|
It works, but the icons are a bit blurry: This is because the icon is 256x256px and the line width is 12px. Scaled down to 16x16, this give a line width of 0.75px. I came up with the following as a more pixel-perfect version on a 16x16 baseline: <?xml version="1.0" encoding="UTF-8"?>
<svg width="16" height="16" version="1.1" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
<circle cx="8.5" cy="8.5" r="5.85" fill="none" stroke="#000" stroke-width="1.3"/>
<g fill="#000">
<circle cx="8.5" cy="8.5" r="2"/>
<rect x="11.5" y="8" width="4.5" height="1"/>
<rect x="1" y="8" width="4.5" height="1"/>
<rect x="8" y="11.5" width="1" height="4.5"/>
<rect x="8" y="1" width="1" height="4.5"/>
</g>
</svg> |
|
I updated the icon with the one @lmoureaux contributed; please check I got the license file right. |
blabber
force-pushed
the
feature/autoscroll_techtree
branch
from
69188ec to
c05ce86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to conveniently scroll the technology tree to the currently researched technology or the technology goal. A button next to the corresponding combo box is available to the user for this purpose.
In the absence of a suitable icon, the buttons currently have the mnemonic label “L” for “Locate”.